chore: PR template and validation updates#3577
Closed
michalChrobot wants to merge 14 commits intodevelop-2.0.0from
Closed
chore: PR template and validation updates#3577michalChrobot wants to merge 14 commits intodevelop-2.0.0from
michalChrobot wants to merge 14 commits intodevelop-2.0.0from
Conversation
…ore mandatory sections
Member
Author
|
Note that currently backport-verification and Pull Request Trigger are still required as those are taken from repo settings and I need to modify those (which will affect all other PRs) to make 100% sure that my changes work as expected. When we will agree to merge this PR then I will
So just notice that it may take me up to 20m of possible disruption. After that ALL PRs will need to pull latest changes so they work correctly |
5 tasks
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR aims to address some areas for the ease of Playtesting and validation of our changes. Important to note are the following changes:
Updated PR template with more sections where (REQUIRED for a PR to be merged) Documentation, Testing and QA, and Backport sections. I renamed the git workflow and I will update the name in the settings when merging this PR so for now you can see backport-verification pending since it doesn't exist anymore.
Newly introduced sections are
Such updated PR template will look as follows

Another thing to note is that Documentation section was added to the changelog to group any changes of this kind (since it would be unintuitive to count them as fixed or added)
One more thing that I'm updating is that I failed to notice that targets and drafts conditions are configured as separate items in a list. In our CI, basic triggers in a list are combined with an OR operator, meaning the job will run if any of the conditions are met. This lead to test being executed on draft PRs. What I'm changing is
Note that the test will execute now on whatever branch if we will specifically want that (by typing /ci ngo)
Jira ticket
MTT-12822
Documentation
No documentation changes or additions were necessary.
Testing & QA
This change won't affect users and focuses around our workflow and templates so no testing is needed
Backport
Will be backported when we agree to the shape of it